fix(iaas): print valid JSON/YAML output for list cmds by j1n-o9r · Pull Request #1365 · stackitcloud/stackit-cli

j1n-o9r · 2026-04-13T09:57:50Z

Description

relates to STACKITCLI-241 / #893

Addition: I encountered a missing --limit-flag within the stackit security-group list command and directly fixed this after consulting @marceljk

Testing Instructions

Test for every list command that is changed (like f.e. stackit server list) if the command returns the expected outputs like:

stackit server list -> Expected: No servers found for project "xxx"
stackit server list --output-format json -> Should output valid JSON
stackit server list --output-format yaml -> Should output valid YAML

Mock responses if testing against API is not possible.

Checklist

Issue was linked above
Code format was applied: make fmt
Examples were added / adjusted (see e.g. here)
Docs are up-to-date: make generate-docs (will be checked by CI)
Unit tests got implemented or updated
Unit tests are passing: make test (will be checked by CI)
No linter issues: make lint (will be checked by CI)

rubenhoenle · 2026-04-14T08:23:56Z

Missing:

stackit-cli/internal/cmd/security-group/list/list.go

Line 72 in 83cf194

params.Printer.Info("No security groups found for project %q", projectLabel)
stackit-cli/internal/cmd/public-ip/list/list.go

Line 88 in 83cf194

params.Printer.Info("No public IPs found for project %q\n", projectLabel)
stackit-cli/internal/cmd/volume/list/list.go

Line 85 in 83cf194

params.Printer.Info("No volumes found for project %q\n", projectLabel)
stackit-cli/internal/cmd/volume/performance-class/list/list.go

Line 86 in 83cf194

params.Printer.Info("No volume performance class found for project %q\n", projectLabel)
stackit-cli/internal/cmd/volume/snapshot/list/list.go

Line 82 in 83cf194

params.Printer.Info("No snapshots found for project %q\n", projectLabel)
stackit-cli/internal/cmd/key-pair/list/list.go

Line 81 in 83cf194

params.Printer.Info("No key pairs found\n")
stackit-cli/internal/cmd/image/list/list.go

Line 91 in 83cf194

params.Printer.Info("No images found for project %q", projectLabel)
stackit-cli/internal/cmd/affinity-groups/list/list.go

Line 74 in 83cf194

params.Printer.Outputln("No affinity groups found")

... and maybe more. Please check carefully 😅

j1n-o9r · 2026-04-15T07:24:10Z

Missing:

stackit-cli/internal/cmd/security-group/list/list.go

Line 72 in 83cf194

params.Printer.Info("No security groups found for project %q", projectLabel)

stackit-cli/internal/cmd/public-ip/list/list.go

Line 88 in 83cf194

params.Printer.Info("No public IPs found for project %q\n", projectLabel)

stackit-cli/internal/cmd/volume/list/list.go

Line 85 in 83cf194

params.Printer.Info("No volumes found for project %q\n", projectLabel)

stackit-cli/internal/cmd/volume/performance-class/list/list.go

Line 86 in 83cf194

params.Printer.Info("No volume performance class found for project %q\n", projectLabel)

stackit-cli/internal/cmd/volume/snapshot/list/list.go

Line 82 in 83cf194

params.Printer.Info("No snapshots found for project %q\n", projectLabel)

stackit-cli/internal/cmd/key-pair/list/list.go

Line 81 in 83cf194

params.Printer.Info("No key pairs found\n")

stackit-cli/internal/cmd/image/list/list.go

Line 91 in 83cf194

params.Printer.Info("No images found for project %q", projectLabel)

stackit-cli/internal/cmd/affinity-groups/list/list.go

Line 74 in 83cf194

params.Printer.Outputln("No affinity groups found")

... and maybe more. Please check carefully 😅

Sorry, I mistakenly understood the examples in the ticket as acceptance criteria and did not check the other resources. I will go through all and add the missing parts.😅

rubenhoenle · 2026-04-20T17:42:00Z

@j1n-o9r We currently have a lot of merge conflicts here, could you please resolve them before one of the collegues starts with a review? 😅

github-actions · 2026-05-19T05:40:43Z

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

… any items via outputResult function instead of returning nil bluntly. adapted tests therefore.

…ions

Co-authored-by: Ruben Hönle <git@hoenle.xyz>

…o deal with nil values since it is required anyways

… string for not having to deal with nil values since it is required anyways

…tas is empty

j1n-o9r marked this pull request as ready for review April 13, 2026 15:07

j1n-o9r requested a review from a team as a code owner April 13, 2026 15:07

j1n-o9r marked this pull request as draft April 15, 2026 12:52

j1n-o9r force-pushed the fix/STACKITCLI-241-iaas-json-list-output branch 3 times, most recently from eaa4afb to 9b8c40d Compare April 22, 2026 10:35

j1n-o9r marked this pull request as ready for review April 22, 2026 11:46